Some Notes after tesing:

- alignment of icons is not optimal?

- grid header is no longer needed

- second column should expand to full with

- edit uses current values, but should use pending values?

- we need a 'Revert' button

- edit deleted value should be possible, and re-enabling the config?

> They also other things to fix,
> 
> 1)
> If a pending device exist,but no current device, (a new device)
> 
> we should disable edit button.
> (and maybe add a button to remove pending device)

I think it is perfectly valid to edit pending changes. I think qemu-server
patches
can handle that without problems?

> 2) for nic add (in gui), currently we auto find the next nic number from
> config.
>    That mean than we trying to add multiple nic, the pending nic is always
> replaced by the new one.
>    Maybe can we add a id field in form, same than disks.

Why don't we simply compute the correct value for next nic number, considering
pending and deleted nics? 

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to