maybe,could we add kvm_user_version() detection before enable this feature ?
(I have checked with discard or not on virtio-blk, it's working fine with last qemu) ----- Mail original ----- De: "Alexandre DERUMIER" <aderum...@odiso.com> À: "Dietmar Maurer" <diet...@proxmox.com> Cc: pve-devel@pve.proxmox.com Envoyé: Mardi 28 Octobre 2014 11:23:01 Objet: Re: [pve-devel] problems with detect-zeroes Oh, in the forum post: #apt-mark hold pve-qemu-kvm So, user is using an old version of qemu-kvm without detect-zeroes support ----- Mail original ----- De: "Alexandre DERUMIER" <aderum...@odiso.com> À: "Dietmar Maurer" <diet...@proxmox.com> Cc: pve-devel@pve.proxmox.com Envoyé: Mardi 28 Octobre 2014 11:18:36 Objet: Re: [pve-devel] problems with detect-zeroes >>id=drive-virtio0,discard=on,aio=native,cache=none,detect-zeroes=unmap I think this is because virtio-blk don't support discard if discard=on detect-zeroes=unmap else detect-zeroes=on I'll retest right now, I'll keep you in touch ----- Mail original ----- De: "Dietmar Maurer" <diet...@proxmox.com> À: "Alexandre DERUMIER (aderum...@odiso.com)" <aderum...@odiso.com> Cc: pve-devel@pve.proxmox.com Envoyé: Mardi 28 Octobre 2014 10:10:51 Objet: problems with detect-zeroes Hi Alexandre, see: http://forum.proxmox.com/threads/20165-After-upgrading-from-3-2-to-3-3-old-pve-qemu-kvm-ceph-vm-doesnt-start but you wrote in the commit: > No impact if the block driver don't support it yet (like rbd) So what is wrong? _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
