Well, after review I do not like all that code anymore ;-) what if we add an 'ahci' option instead:
ahci: 0|1 If set, we use ahci/sata for ide drives, else we use normal ide mode. That way we have the same logic as we use for scsi (scsihw). We would also save some pci addresses. Using ide and sata at same time does not really make sense? What do you think? > -----Original Message----- > From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel- > boun...@pve.proxmox.com] On Behalf Of Alexandre DERUMIER > Sent: Mittwoch, 29. August 2012 12:29 > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] ahci unmigratable > > I see you have just added sata to pve-manager, > > ahci is unmigratable for the moment, > http://git.qemu.org/?p=qemu.git;a=blob;f=hw/ide/ich.c;h=272b7734b55f5e7 > 77d43c272ffbef8cc9ade0ac9;hb=HEAD > static const VMStateDescription vmstate_ahci = { > .name = "ahci", > .unmigratable = 1, > }; > > > so I think we should add a check for live migration > > _______________________________________________ > pve-devel mailing list > pve-devel@pve.proxmox.com > http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
