Re: [PATCH pve-manager 5/8] ui: Add CPU flag editor for custom models

[Arthur Bied-Charreton]

On Thu, Mar 26, 2026 at 04:40:12PM +0100, Maximiliano Sandoval wrote:
> Arthur Bied-Charreton <a.bied-charre...@proxmox.com> writes:
> 
[...]
> >          {
> > +            text: gettext('Set'),
> 
> This would benefit from a TRANSLATORS comment. Is this a noun (set as in
> set theory)? is it a verb (to set)? From the point of view of
> translators there is not enough context to decide.
> 
It is 'to set' (German 'setzen'), but on second thought it does not feel
right to describe a value with a verb like this, maybe something like
'Value' would be better. Thanks for the feedback!
[...]
> > +                                'A custom CPU model using 
> > acceleration-specific flags should only be assigned to VMs configured with 
> > the matching acceleration type, i.e., `kvm: off` for TCG, or `kvm: on` for 
> > KVM.',
> 
> I would recommend to use quotes `"`, single-quotes `'` in user-facing
> strings. Backticks are a markup/markdown concept. See [1].
> 
> off-topic: In principle one should use “” rather than "", but I don't
> think there is precedent for this the codebase.
> 
> [1] https://en.wikipedia.org/wiki/Quotation_mark#In_English
> 
You're right, those look weird when not rendered. Will change that in
v2, thanks!
> 
[...]
> -- 
> Maximiliano