On 19.03.2026 11:32, Wolfgang Bumiller wrote: > On Thu, Mar 12, 2026 at 03:26:41PM +0100, Gabriel Goller wrote: > > Add a new serializer which uses only the builtin (include_str!) templates > > from > > the `proxmox-frr-templates` package in `/usr/share/proxmox-frr/templates` to > > generate the frr config file. Also update the `build_fabric` function and > > the > > tests accordingly. > > > > Use the `phf` crate to store them in a const map. > > ^ This is the only thing I have an issue with in the `proxmox-ve-rs` > part of this series, but it's quite a lot, so could have easily missed > things. > > A `LazyLock` or `sortable!()`+`binary_serach` should be fine here IMO. > It's a very tiny map.
Done. Thanks for the review!
