One tiny nit inline (could also be fixed while applying), other than that please consider it:
Reviewed-by: Christoph Heiss <[email protected]> On Thu Mar 5, 2026 at 10:16 AM CET, Dominik Csapak wrote: > This gets us the missing description that used to be in sysfs. > > In case this is an SR-IOV virtual function, we have to get the physical > device first since only that is a valid device for querying with NVML. > > 'pci_dev_physfn_id' is only used here currently so it's a local sub, but > if we need it in more places, a good place could be 'PVE::SysFSTools' or > 'PVE::QemuServer::PCI'. > > Signed-off-by: Dominik Csapak <[email protected]> > --- > src/PVE/QemuServer/PCI/Mdev.pm | 45 ++++++++++++++++++++++++---------- > 1 file changed, 32 insertions(+), 13 deletions(-) > > diff --git a/src/PVE/QemuServer/PCI/Mdev.pm b/src/PVE/QemuServer/PCI/Mdev.pm > index 3b42ce2d..51dca474 100644 > --- a/src/PVE/QemuServer/PCI/Mdev.pm > +++ b/src/PVE/QemuServer/PCI/Mdev.pm > @@ -2,11 +2,28 @@ package PVE::QemuServer::PCI::Mdev; > > use v5.36; > > +use File::Basename; > + > +use PVE::RS::NVML; Nit: Needs the dependency entry on libpve-rs-perl in d/control recorded.
