Am 16.03.26 um 10:06 AM schrieb Maximiliano Sandoval: > When doing a linked clone of a template, the task log, journal, nor the > UPID of the task will log the VMID of the newly created VM. > > We add a log message right before writing the config. This affects both > full and linked clones. >
I wonder if it should rather be done at the very beginning of the task? Then you also know what the intended ID was for a failed task, which maybe could help with tracking left-overs from the operation. Note that the configuration is already written after each disk, not just at the very end. > Signed-off-by: Maximiliano Sandoval <[email protected]> > --- > > Notes: > Note that when creating linked clones we do not update the creation time > in the config. > > When cloning two VMs from a template (created with "vanilla" settings), > if one uses the same 'name' for both clones, then the only differences > between the linked clones that could be used to tell them apart are the > MAC address, the VM id, smbios UUID, and the vmgenid, all of which are > randomly generated. > > I think it makes sense to update the creation time too. But for now, See: https://bugzilla.proxmox.com/show_bug.cgi?id=6156 https://git.proxmox.com/?p=qemu-server.git;a=commit;h=26b443c8461b3ddccffc944897af6d67a96ed7bd > being able to tell from the task log which VM correspond to which > qmclone task would be an improvement already. > > Tested: > - create a template with id 101 > - running qm clone 101 202 --full 0 and checked the output: > > create linked clone of drive scsi0 (local-lvm:base-101-disk-0) > writing configuration of cloned VM with ID 202 > > src/PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index 1e226f6f..43e56837 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -4589,6 +4589,7 @@ __PACKAGE__->register_method({ > delete $newconf->{pending}; > } > > + print("writing configuration of clone with ID $newid\n"); > PVE::QemuConfig->write_config($newid, $newconf); > > PVE::QemuServer::Network::create_ifaces_ipams_ips($newconf, > $newid);
