Something that was missing from Fiona's comments was giving the "hint" CSS class to the "Deprecated" part of the old checkbox's label. I was not sure how to make that work in ExtJS.
The migration would work as follows: - The new key takes preference over the old one so using the old one is OK. - If the key is in the config file and explicitly disabled then the old checkbox would be displayed - But we delete the deprecated key from the config if it was explicitly enabled (it is the default) after performing any change One could additionally do some extra work where setting the new key will also set the old value, but for the sake of simplicity I think this is a good start. I added to my TODO list to add a migration check to the pve9to10 script. Differences from v1: - Rephrased the user-facing strings - Fix a typo in a commit message - Expand some commit messages - Hide the checkbox not only if it was undefined, but also if it was explicitly set to the default value Maximiliano Sandoval (7): ui: utils: support guest-fsfreeze at render_qga_features ui: qga: merge translatable string ui: qga: move freeze-fs-on-backup to advanced opts ui: qga: note that freeze-fs-on-backup is deprecated ui: qga: add checkbox for guest-fsfreeze ui: qga: call parameter me instead of this ui: qga: hide freeze-fs-on-backup conditionally www/manager6/Utils.js | 2 + www/manager6/form/AgentFeatureSelector.js | 72 ++++++++++++++++++++--- 2 files changed, 66 insertions(+), 8 deletions(-) -- 2.47.3
