Adds a more flavorful description to the NUMA policy option based on both qemu and the kernel's documentation. For now we simply paste the contents of the `qemu-system-x86_64(1)` manual.
One open question is if there is any precedent for URIs in verbose descriptions. This came up in a couple of cases in enterprise support where information was requested regarding the NUMA policy. Regarding the 'default' value. NUMA policies were added on our side at 2ed5d5724 but there is no mention of why the 'default' policy is not used as a default. On QEMU's side the first appearance of policies was a 2.1.0 (Aug 2014) and there was a 'default' value at that stage. While one could use the 'default' policy when the property is not set, I personally would prefer if "not setting the key in the config" can be represented by an explicit value in the config. What was tested: - Create a VM with 2048 MiB of ram and 1 CPU with numa enabled - Ran: - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0 - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=default - qm set 100 --numa0 cpus=0,memory=2048,hostnodes=0,policy=bind - Verify in each case that the memory-backend-ram has the right policy in the qm showcmd 100 output Differences from v1: - Add more to the commit messages - sed s/numa/NUMA - Read default value from the schema directly - Sneak a commit fixing the unit in a comment - Say what was tested in cover letter - Explain why a default value was added to the schema instead of just using it instead of dying in the cover letter Maximiliano Sandoval (3): memory: add verbose_description to NUMA policy memory: add default NUMA allocation policy memory: fix unit in heuristic comment src/PVE/QemuServer/Memory.pm | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) -- 2.47.3
