both commit message could be longer (or be there at all ;) )
one could note e.g. that the description was taken
from the qemu manpage.

aside from that and the one comment on 2/2 (see separate mail) patches LGTM

On 3/12/26 11:50 AM, Maximiliano Sandoval wrote:
Adds a more flavorful description to the NUMA policy option based on
both qemu and the kernel's documentation. For now we simply paste the
contents of the `qemu-system-x86_64(1)` manual.

One open question is if there is any precedent for URIs in verbose
descriptions.

This came up in a couple of cases in enterprise support where more
information was requested regarding the policy.

Regarding the 'default' value. NUMA policies were added on our side at
2ed5d5724 but there is no mention of why the 'default' policy is not
used as a default. On QEMU's side the first appearance of policies was a
2.1.0 (Aug 2014) and there was a 'default' value at that stage.

Maximiliano Sandoval (2):
   memory: add verbose_description to numa policy
   memory: add default numa allocation policy

  src/PVE/QemuServer/Memory.pm | 17 ++++++++++++++---
  1 file changed, 14 insertions(+), 3 deletions(-)





Reply via email to