On Thu Feb 26, 2026 at 9:46 AM CET, Maximiliano Sandoval wrote:
> See the first commit for more information.
>
> Regarding adding the manual page: It is not very obvious where to find the
> documentation for the value (I was personally interested in the units for
> zfs_arc_max). Only after a `man -Kw zfs_arc_max` I found zfs(4) (as its sole
> output).
>
> I also considered just saying that we only fallback to ZFS' defaults without
> specifying the exact values, perhaps only that they quite high compared to 
> 10%.
>
> Differences from v1:
>  - Document that we used ZFS' defaults before 8.1
>  - Use lowercase in commit message
>
> Maximiliano Sandoval (2):
>   local-zfs: rephrase ARC limit
>   local-zfs: add reference to the zfs(4) manual
>
>  local-zfs.adoc | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

other than the small nit i left on the first commit, this looks alright
to me, consider this:

Reviewed-by: Shannon Sterz <[email protected]>



Reply via email to