On 06.03.2026 11:35, Stefan Hanreich wrote: > On 3/5/26 11:03 AM, Gabriel Goller wrote: > > The frr object in perl which stores the whole frr config is now also > > modeled in rust, so it changed a bit. Adjust the frr.conf.local merging > > code so that the frr.conf.local is still merged correctly. This makes > > use of the `custom_frr_config` properties scattered in many rust types. > > So if we encounter a line in frr.conf.local that we need to merge, we > > just throw it into this string vec and render it as-is. > > this commit message could use some additional information, particularly > about the route-map sequence fudging and why we do it. Also we should > explain here that we settled on supporting appending / creating every > section that is parsed here explicitly. Some short information on the > ordering changes in the generated FRR configuration, when merging > frr.conf.local would be helpful as well. We might know all of this now, > but this will be super helpful when revisiting this.
Done, thanks for the review!
