this is a combination of my previous patches[0][1] (v3 because [0] was already v2)
First we make the cleanup handling more consistent (1/3) then we check explicitely for the backup lock to improve the error message for stop backup mode (2/3) and then we fix #7119 by waiting up to 30s for a possibly still running guest to stop (e.g. this can occur when using usb passthrouh) (3/3) changes from v2/RFC: * use 'vm_running_locally' for getting the pid * improve error messages * use a 'use_old_cleanup' flag that will be auto-removed by a reboot to signal if we can use the new cleanup logic or the old 0: https://lore.proxmox.com/pve-devel/[email protected]/ 1: https://lore.proxmox.com/pve-devel/[email protected]/ Dominik Csapak (3): cleanup: refactor to make cleanup flow consistent qm cleanup: die early when encountering a running stop mode backup fix #7119: qm cleanup: wait for process exiting for up to 30 seconds debian/preinst | 16 +++++++++++++++ src/PVE/CLI/qm.pm | 35 +++++++++++++++++++++++++++----- src/PVE/QemuServer.pm | 14 +++++++++++++ src/PVE/QemuServer/RunState.pm | 28 +++++++++++++++++++++++++ src/test/MigrationTest/QmMock.pm | 16 +++++++++++++++ 5 files changed, 104 insertions(+), 5 deletions(-) create mode 100755 debian/preinst -- 2.47.3
