..and add more logging when issuing fsfreeze guest commands.
The new setting takes precedence over freeze-fs-on-backup and deprecates the
former.
- At the moment taking a snapshot without RAM does not log whether there was a
freeze/thaw, we add logs when issuing freezes/thaws.
- The patch does not result in an extra log line when making a Backup in
snapshot mode.
- When it is easy to do so, we log if the fsfreeze command was not issued due to
mismatch between the agent running and the config, e.g. when say that we
skipped it if the agent is enabled bu the configuration says we shouldn't.
What was tested:
- Backups of a VM with and another without guest-fsfreeze enabled. They both
print a message indicating that a fsfreeze happend.
- A live clone of a VM with and another without guest-fsfreeze enabled. They
both print a message indicating that a fsfreeze happend.
- Snapshot of a VM with and another without guest-fsfreeze enabled. Only the
format logged a message indicating that a fsfreeze happened.
Differences from v3:
- Instead of removing logfunc statements and adding a print to the base
__snapshot_freeze we add a print on the snapshot method which was the one
missing a log. This means we do not need changes in pve-container anymore.
- Add a helper to thaw a qemu guest. This is done only for readability.
- Read the guest config right at the start of the worker
- Rebase on top of master
Differences from v2:
- Print a message on live clones when fsfreeze is skipped due to config
- Clean up code a bit
- rebase
- Fix a typo
Differences from v1:
- Add setting to enable/disable fsfreeze commands
- Change wording in one log message
qemu-server:
Maximiliano Sandoval (8):
add a guest-fsfreeze qga setting
api: clone_vm: follow guest-fsfreeze setting
fix #1964: follow guest-fsfreeze setting on check freeze needed
agent: add a guest_fsthaw helper
port users of guest-fsfreeze-thaw users to helper
block job: log when a fsfreeze could not happen
block job: mirror: reword fsfreeze log entry
deprecate freeze-fs-on-backup qga setting
src/PVE/API2/Qemu.pm | 5 ++++-
src/PVE/QemuConfig.pm | 5 +++--
src/PVE/QemuServer/Agent.pm | 31 ++++++++++++++++++++++++++++++-
src/PVE/QemuServer/BlockJob.pm | 18 ++++++++++++------
src/PVE/VZDump/QemuServer.pm | 9 ++++++---
5 files changed, 55 insertions(+), 13 deletions(-)
pve-guest-common:
Maximiliano Sandoval (1):
abstract config: print when {,un}freezing a fs
src/PVE/AbstractConfig.pm | 2 ++
1 file changed, 2 insertions(+)
Summary over all repositories:
6 files changed, 57 insertions(+), 13 deletions(-)
--
Generated by murpp 0.9.0
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
