The regex for validating NICs in pve-common starts with /^[a-z].../ getting 'name must start with a letter' to a pinned nic-name of 'ABC' is confusing. Additionally there was a discrepancy in validating the nic-name in the rust-based installers (is_ascii_alphabetic also matches upper-case letters, whereas the perl-regex required [a-z])
Align the validation with the version in pve-common. Tested by running the installer with the patch applied in TUI mode (it creates an error for 'ABC', while accepting it without the patch) and in GUI mode (to verify the error-message mentions lower-case letter). Stoiko Ivanov (2): common: pinning: require first character to be lower-case ascii sys: net: fix error-message for interface names first character Proxmox/Sys/Net.pm | 2 +- proxmox-installer-common/src/options.rs | 8 ++++---- test/validate-link-pin-map.pl | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) -- 2.47.3 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
