Avoid sending the parameter with the default value when it's not necessary, improving compatibility in cases where the ha-managed param is not recognized (e.g. when creating a guest on another node that does not support the parameter). Setting uncheckedValue to undefined results in the value of the checkbox not being submitted upon submission of the form if the checkbox is left unchecked or explicitly set unchecked [0]. The API already considers the ha-managed param optional and sets a default value of 0.
Even though undefined is the default value for uncheckedValue, set it explicitly to make the intent clearer. [0] https://docs.sencha.com/extjs/7.0.0/classic/Ext.form.field.Checkbox.html#cfg-uncheckedValue Signed-off-by: Michael Köppl <[email protected]> --- www/manager6/lxc/CreateWizard.js | 4 ++-- www/manager6/qemu/CreateWizard.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index f35709f14..46835e7ae 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/manager6/lxc/CreateWizard.js @@ -85,8 +85,8 @@ Ext.define('PVE.lxc.CreateWizard', { { xtype: 'proxmoxcheckbox', name: 'ha-managed', - uncheckedValue: 0, - defaultValue: 0, + // only submit value of checkbox if checked + uncheckedValue: undefined, fieldLabel: gettext('Add to HA'), }, ], diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js index e0c56bc0b..341324c85 100644 --- a/www/manager6/qemu/CreateWizard.js +++ b/www/manager6/qemu/CreateWizard.js @@ -99,8 +99,8 @@ Ext.define('PVE.qemu.CreateWizard', { { xtype: 'proxmoxcheckbox', name: 'ha-managed', - uncheckedValue: 0, - defaultValue: 0, + // only submit value of checkbox if checked + uncheckedValue: undefined, fieldLabel: gettext('Add to HA'), }, ], -- 2.47.3 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
