On 15.11.2025 18:16, Thomas Lamprecht wrote: > Am 27.05.25 um 16:04 schrieb Gabriel Goller: > > Refactor AgentIPView to be generic over container and vms. Reuse it in > > the Container Summary to show the ip addresses of the container. Also > > make the GuestSummary scrollable, as it can potentially be bigger > > (because of the ip-addresses that can be shown) than 300 (which is the > > size of the RRD graphs). > > > > Signed-off-by: Gabriel Goller <[email protected]> > > --- > > www/manager6/Makefile | 2 +- > > www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++- > > www/manager6/panel/GuestSummary.js | 1 + > > .../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++-------- > > 4 files changed, 151 insertions(+), 71 deletions(-) > > rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%) > > > > > > I rechecked the changes and I disliked the callback approach, so I reworked > this to rather using a base class and two specialized sub-classes, one for > VMs and one for CTs. This encapsulates underlying details better, one that > instantiates these widgets somewhere should not have to care about (plus > doing so crowds the use-sites code). > > That said, your changes itself where quite well structured, so adapting it > wasn't much of a hassle, besides one ExtJS bug (IMO) getting in my way > quite a bit, see another follow-up for some more info on that though. > .
Thanks for tackling this! _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
