On Thu Nov 13, 2025 at 10:30 AM CET, Daniel Kral wrote: > On Wed Nov 12, 2025 at 11:49 AM CET, Thomas Lamprecht wrote: >> Am 27.10.25 um 17:46 schrieb Daniel Kral: >>> Needs a build dependency bump for >>> librust-proxmox-resource-scheduling-dev and a versioned breaks for >>> pve-ha-manager. >> >> The latter only due to the (signature) change to add_service_usage_to_node, >> or? >> While versioned breaks can be done, if it's somewhat easy to avoid them it's >> always better to do so, especially as it makes downgrades much easier >> >> Can we keep backward compat without having to bend to >> much backwards? E.g. adding a new method for the new more granular way while >> keeping add_service_usage_to_node as is, like >> "record_service_usage_for_node" (or >> just slap a 2 at the end of the method name is also a simple trick that, >> while not >> beautiful, works and avoids bikeshedding). > > I'd go for that route, but the new `sid` parameter is needed to track on > which node a service puts its load on, i.e. where we need to remove it > later. That's information we didn't get before and we unfortunately > cannot make it optional, e.g. shoving it in the already existing > StaticNodeUsage as a Option<_> field. (Haven't tested it yet, but this > shouldn't be an API break for perlmod?) > > Another approach would be to allow both the non-granular and granular > behavior to coexist - at least for the 9.x series, even though it might > be a little ugly, it's probably not too bad. > > What do you think?
As noted off-list, I've gone with staying the breaking change for v4 now, as there's no neet way to do this otherwise. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
