Regarding the change in Restore.js: In certain languages (e.g. Spanish) CT and VM would have different genders, hence it is not possible to use the same string without having at least one wrong translation.
Regarding the batch size label, the `b` in batch size is not very obvious in meaning from a i18n perspective. Signed-off-by: Maximiliano Sandoval <[email protected]> --- www/manager6/dc/MetricServerView.js | 2 +- www/manager6/window/Restore.js | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager6/dc/MetricServerView.js b/www/manager6/dc/MetricServerView.js index 1cb9d516..ebfdf2e4 100644 --- a/www/manager6/dc/MetricServerView.js +++ b/www/manager6/dc/MetricServerView.js @@ -369,7 +369,7 @@ Ext.define('PVE.dc.InfluxDBEdit', { { xtype: 'proxmoxintegerfield', name: 'max-body-size', - fieldLabel: gettext('Batch Size (b)'), + fieldLabel: gettext('Batch Size (bits)'), minValue: 1, emptyText: '25000000', submitEmpty: false, diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index 690116df..f376da9a 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window/Restore.js @@ -93,12 +93,11 @@ Ext.define('PVE.window.Restore', { }; if (view.vmid) { - confirmMsg += `. ${Ext.String.format( - gettext('This will permanently erase current {0} data.'), - view.vmtype === 'lxc' ? 'CT' : 'VM', - )}`; if (view.vmtype === 'lxc') { + confirmMsg += `. ${gettext('This will permanently erase current CT data.')}`; confirmMsg += `<br>${gettext('Mount point volumes are also erased.')}`; + } else { + confirmMsg += `. ${gettext('This will permanently erase current VM data.')}`; } Ext.Msg.confirm(gettext('Confirm'), confirmMsg, function (btn) { if (btn === 'yes') { -- 2.47.3 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
