On Wed Sep 24, 2025 at 6:07 PM CEST, Michael Köppl wrote:
> This patch series aims to fix #6613 [0]. Although an implementation was
> proposed in the past, it was not applied since it was unclear how to
> handle the case where the removed resource is the last resource in a
> rule.

Hi!

I left one inline note for the ConfirmRemoveDialog.. I'm not sure if we
should change all other usages for the special case, but as I said, it
might just be nit-picking from my end.

We could also just go for a light-weight yes/no confirm dialog without
replacing the users of Proxmox.window.SafeDestroy but only make the HA
resource delete button the only user of ConfirmRemoveDialog.

Otherwise, it looks good and works as expected. With the inline note /
above addressed, consider this as:

Tested-by: Daniel Kral <[email protected]>
Reviewed-by: Daniel Kral <[email protected]>


_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to