--- Begin Message ---
I've been using the pve manager vzdump hook to do custom things after a backup
is done e.g. backup some more files, call a webhook for monitoring, etc.
However there is currently a big drawback, the job state does not get passed,
so there is no way to tell whether the backup was succesfull or not.
I recently had some drive issues which resulted in 1 vm backup failing, if i
had not checked the mailnotification i would have never catched that.
e.g. /etc/vzdump.conf with `script: /root/backuphook.sh`
cat << 'EOF' > /root/backuphook
#!/bin/bash
cd /tmp
DATE=$(date +"%d.%m.%Y")
FILENAME="backup_$DATE.env"
echo "" >> "$FILENAME"
chmod 700 "$FILENAME"
echo "Arguments: $@" >> "$FILENAME"
printenv >> "$FILENAME"
echo -e "\n\n" >> "$FILENAME"
EOF
all the backuphook gets passed is the following:
```
Arguments: job-end
PWD=/tmp
LVM_SUPPRESS_FD_WARNINGS=1
SHLVL=1
STOREID=backup
LC_ALL=C
OLDPWD=/
_=/usr/bin/printenv
```
No way to tell whether the backup was succesfull, can't even grep the backup
log for it etc.
I've been using this simple patch to pass the errcount to the `job-end` and
`job-abort` stage
This way you can check now if it was succesfull or not, e.g:
cat << 'EOF' > /root/backuphook
#!/bin/bash
if [[ "$*" != *job-end* ]]; then
exit 0
fi
if [ "$ERRCOUNT" -gt 0 ]; then
# alert on broken backup (could be drive issues etc.)
# call webhook / trigger monitoring alert
else
# do some more things after succesfull backup
fi
EOF
Would be great if this could be merged.
Best regards
Constantin
Constantin Herold (1):
feat: pass backup status to hook script on job-end/job-abort
PVE/VZDump.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.51.0
--- End Message ---
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
