Changes in v2:
* use eval+warn around new detach() call sites, as failure should not
be critical there.
Add a new noerr argument to mon_cmd() to allow callers to opt-in to
handling errors themselves.
Without passing 'noerr' to mon_cmd(), errors are logged to the system
journal. In the blockdev module, in attach() and detach(), there are
two mon_cmd() calls that are expected to fail in some scenarios for
which the errors should not be logged.
Again in the blockdev module, the functions for deletion and replace
had the same issue. Have them re-use the detach() function.
Fiona Ebner (3):
qmp client: add $noerr argument
blockdev: attach/detach: silence errors for QMP commands for which
failure may be expected
blockdev: delete/replace: re-use detach() helper
src/PVE/QMPClient.pm | 8 ++++---
src/PVE/QemuServer/Blockdev.pm | 16 ++++++--------
src/PVE/QemuServer/Monitor.pm | 40 +++++++++++++++++++++++++++++++---
3 files changed, 49 insertions(+), 15 deletions(-)
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
