Note: This is POC PATCH Since the primary responsibility of the login manager is to handle login-related features, having the settings screen code defined within the package causes unnecessary coupling. Whenever a new configuration or app-related setting (e.g., privacy policy URL, help link, app version string) needs to be added, the package must be modified—even if the change is unrelated to login functionality. When we had only one config (SSL) it was fine. Since new widgets needs to be added it might be better to seperate it.
To avoid this and to make it easier to add global settings configuration widgets in the future, the direct navigation to `ProxmoxGeneralSettingsForm` from `proxmox_login_manager` has been removed. Instead, the screen is now defined within the `pve_flutter_frontend`, and the `ProxmoxGeneralSettingsForm` is used as a widget inside that screen. pve_flutter_frontend: Shan Shaji (1): refactor: ui: add new settings page and use existing ssl toggle widget lib/main.dart | 8 ++++++++ lib/pages/pve_settings_page.dart | 23 +++++++++++++++++++++++ 2 files changed, 31 insertions(+) create mode 100644 lib/pages/pve_settings_page.dart proxmox_login_manager: Shan Shaji (1): refactor: ui: move settings page to `pve_flutter_frontend` lib/proxmox_general_settings_form.dart | 58 +++++++++++--------------- lib/proxmox_login_form.dart | 5 +-- lib/proxmox_login_selector.dart | 13 +++--- 3 files changed, 31 insertions(+), 45 deletions(-) Summary over all repositories: 5 files changed, 62 insertions(+), 45 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
