The $volname variable is never modified in the function, so it doesn't need to be passed into the $get_snapname_from_path closure.
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> --- src/PVE/Storage/LVMPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 67fcfbd..705585f 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -800,7 +800,7 @@ sub volume_snapshot_info { my ($class, $scfg, $storeid, $volname) = @_; my $get_snapname_from_path = sub { - my ($volname, $path) = @_; + my ($path) = @_; my $name = basename($path); if (my $snapname = parse_snap_name($name)) { @@ -829,7 +829,7 @@ sub volume_snapshot_info { my $snapshots = $json_decode; for my $snap (@$snapshots) { my $snapfile = $snap->{filename}; - my $snapname = $get_snapname_from_path->($volname, $snapfile); + my $snapname = $get_snapname_from_path->($snapfile); #not a proxmox snapshot next if !$snapname; @@ -842,7 +842,7 @@ sub volume_snapshot_info { my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { - my $parentname = $get_snapname_from_path->($volname, $parentfile); + my $parentname = $get_snapname_from_path->($parentfile); $info->{$snapname}->{parent} = $parentname; $info->{$parentname}->{child} = $snapname; } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel