The default timeout is not appropriate in all cases, e.g. removing a VirtIO SCSI controller can take more than 5 seconds.
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> --- src/PVE/QemuServer.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index d7398648..9f327955 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -4126,12 +4126,14 @@ sub qemu_deviceaddverify { } sub qemu_devicedelverify { - my ($vmid, $deviceid) = @_; + my ($vmid, $deviceid, $timeout) = @_; + + $timeout //= 5; # need to verify that the device is correctly removed as device_del # is async and empty return is not reliable - for (my $i = 0; $i <= 5; $i++) { + for (my $i = 0; $i <= $timeout; $i++) { my $devices_list = vm_devices_list($vmid); return 1 if !defined($devices_list->{$deviceid}); sleep 1; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel