The 'maxfiles' setting is dropped with Proxmox VE 9, so make having
the setting configured a proper error rather than just a warning.
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
---
NOTE: for both stable-8 and master
PVE/CLI/pve8to9.pm | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index cd8ea038..d0f8cff0 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -649,8 +649,8 @@ sub check_backup_retention_settings {
my $pass = 1;
- my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and
will be removed in a "
- . "future version, use 'prune-backups' instead.";
+ my $maxfiles_msg = "parameter 'maxfiles' was deprecated with PVE 7.x and
is getting dropped"
+ . " with PVE 9.";
eval {
my $confdesc = PVE::VZDump::Common::get_confdesc();
@@ -665,12 +665,12 @@ sub check_backup_retention_settings {
if (defined($param->{maxfiles})) {
$pass = 0;
- log_warn("$fn - $maxfiles_msg");
+ log_fail("$fn - $maxfiles_msg");
}
};
if (my $err = $@) {
$pass = 0;
- log_warn("unable to parse node's VZDump configuration - $err");
+ log_fail("unable to parse node's VZDump configuration - $err");
}
my $storage_cfg = PVE::Storage::config();
@@ -680,7 +680,7 @@ sub check_backup_retention_settings {
if (defined($scfg->{maxfiles})) {
$pass = 0;
- log_warn("storage '$storeid' - $maxfiles_msg");
+ log_fail("storage '$storeid' - $maxfiles_msg");
}
}
@@ -690,12 +690,12 @@ sub check_backup_retention_settings {
# only warn once, there might be many jobs...
if (scalar(grep { defined($_->{maxfiles}) } $vzdump_cron->{jobs}->@*))
{
$pass = 0;
- log_warn("/etc/pve/vzdump.cron - $maxfiles_msg");
+ log_fail("/etc/pve/vzdump.cron - $maxfiles_msg");
}
};
if (my $err = $@) {
$pass = 0;
- log_warn("unable to parse node's VZDump configuration - $err");
+ log_fail("unable to parse node's VZDump configuration - $err");
}
log_pass("no backup retention problems found.") if $pass;
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
