On 2025-07-08 20:20, Michael Köppl wrote:
> Had a closer look at the implementation, which apart from 2 suggestions
> on pve-manager 2/2 looks good.
>
> Quickly had a look at the Backup job details dialog as well and tested
> through the various combinations for notification settings. Information
> for both the notification system and email notifications are displayed
> as expected. I just think the text displayed ("Always use sendmail
> to...") could maybe be replaced by something more concise, as noted in
> more detail on the respective patch.
>
> Please consider this:
> Tested-by: Michael Köppl <m.koe...@proxmox.com>
> Reviewed-by: Michael Köppl <m.koe...@proxmox.com>
>
Thanks a lot for the review, Michael.
I've incorporated some of your suggestions into a v3:
https://lore.proxmox.com/all/20250709081432.91868-1-l.wag...@proxmox.com/T/#t
I've added your T-b and R-b to the first two patches but not the third, since
the third one has changed significantly from v2.
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
