On 2025-06-26 18:06, Michael Köppl wrote:
> This series aims to fix #3711 [0] and streamline the detach/remove
> behavior around volumes that are either mounted into a container or
> attached to a VM as a hard disk. It also contains adds warnings in case
> a volume's underlying storage does not exist anymore. It is a
> continuation of a series from 2022 [1], but makes the following changes:
>
[...]
Gave these changes a quick test on the latest master.
I tested:
- Remove {container,vm} after the the storage has been removed
-> does not fail any more, but shows a warning
- Remove a template if a linked clone exists
-> now fails with an error
Something that I have noticed is that when you have a second disk/mountpoint on
some storage, detach the disk/mountpoint, remove the storage and then
try to remove the unused disk, there is a difference in behavior between
containers and VMs. For VMs, the ununused disk can be removed, while for
containers
the removal fails with:
unused0: unable to apply pending change unused0 : storage 'test' does not
exist
Also did a brief review of the code. I'm not really familiar with these parts
of our stack, but from my point of view these changes look fine.
Tested-by: Lukas Wagner <l.wag...@proxmox.com>
Reviewed-by: Lukas Wagner <l.wag...@proxmox.com>
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
