LGTM, and built + tested fine here,
but maybe someone else also wants to take a look too... (@thomas?)
Does it even make sense to set the targetSdkVersion higher than the compiled
one?
Otherwise, consider this
Reviewed-by: Dominik Csapak <d.csa...@proxmox.com>
Tested-by: Dominik Csapak <d.csa...@proxmox.com>
On 7/2/25 11:10, Shan Shaji wrote:
The current target API level is 34(Android 14). According to
google play requirements the target API level should be
within one year of latest Android release.
To fix the issue update `compileSdkVersion` to 35 (Android 15)
and `targetSdkVersion` to API level 36 (Android 16). The
`compileSdkVersion` was not updated to API level 36 as
`biometric_storage` [5] plugin's compileSdk is 35.
Plugins (pve_flutter_frontend):
- flutter_inappwebview [0]
- shared_preference [1]
- path_provider [2]
- url_launcher [3]
Plugins (proxmox_login_manager):
- shared_preference [4]
- biometric_storage [5]
[0] - https://pub.dev/packages/flutter_inappwebview/versions/6.0.0#requirements
[1] - https://pub.dev/packages/shared_preferences/versions/2.3.4
[2] - https://pub.dev/packages/path_provider/versions/2.1.5
[3] - https://pub.dev/packages/url_launcher/versions/6.3.1
[4] - https://pub.dev/packages/shared_preferences/versions/2.2.3
[5] -
https://github.com/authpass/biometric_storage/blob/63c3dc3cd74729c78e4fc2de54b36e0db9540cbf/android/build.gradle#L34
Signed-off-by: Shan Shaji <s.sh...@proxmox.com>
---
The version was updated as we received an email from Google play
to update the target API level and release a new version before
31st August 2025.
The exact versions of the plugins are taken from the `.lock` file
as we are using the caret versioning for our dependencies in
`pubspec.yaml`.
android/app/build.gradle | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/android/app/build.gradle b/android/app/build.gradle
index bcb364d..a749e46 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -44,7 +44,7 @@ def keystoreSecret =
System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
: keystoreProperties['keyPassword']
android {
- compileSdkVersion 34
+ compileSdkVersion 35
namespace "com.proxmox.app.pve_flutter_frontend"
sourceSets {
@@ -55,7 +55,7 @@ android {
defaultConfig {
applicationId namespace
minSdkVersion 23
- targetSdkVersion 34
+ targetSdkVersion 36
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
