Am 30.06.25 um 14:43 schrieb Fabian Grünbichler: > On June 26, 2025 6:04 pm, Fiona Ebner wrote: >> There currently does not seem to be a good way to obtain information >> about the file child of a node, so add a custom command. The >> query-block and query-named-block-nodes commands lack the necessary >> info and while x-debug-query-block-graph exists, that is explicitly >> only for debugging and experimental. >> >> This is requried for e.g. blockdev-mirror in PVE to determine the >> node below the top throttle node. >> >> Signed-off-by: Fiona Ebner <f.eb...@proxmox.com> >> --- >> >> Alternatively, we could think about adding the node name of the file >> child to the info returned by query-named-block-nodes. I can give that >> a shot and also ask upstream which approach is prefered. > > that might be nice, or alternatively if we go with our custom solution > here for now - give it a prefixed name to avoid potential clashes with a > future upstream variant?
Since the variant mentioned here is much nicer for the unplug-after-mirror scenario and seems quite natural, I'll go with that: https://lore.kernel.org/qemu-devel/20250630141421.1558724-1-f.eb...@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
