Changes in v3: * Make tidy. * After the upstream discussion [0], do not patch QEMU. Instead, make sure that the 'keyring' is set in the storage's configuration and set the rbd_cache_policy on the EFI image itself. For the 'keyring' option, we also need something in pve8to9 so that users that already have a custom configuration for an external Ceph storage are prompted to set it too (an existing configuration is not touched by the proposed patch). See patch 5/9 for details. * Mention that volume is activated before qemu_blockdev_options() is called in docs.
Changes in v2: * Patch QEMU to support both keyring and rbd_cache_policy settings, it is much cleaner than generate per-volume (or technically would even be per-instance, as a volume could be re-used) temporary ceph.conf files. For keyring, we could also make sure to write the path to every storage's ceph.conf in pve8to9 and require it going forward, but supporting the option in QEMU seems to be the simplest. The rbd_cache_policy is truly a per-volume setting in Proxmox VE, which is specifically changed for EFI disks, so ceph.conf is just not the right place for that setting. * Add a special 'hints' option to indicate when it's an EFI disk, so the RBD plugin can set the policy. When using -drive, storage plugins currently give us a path that QEMU understands, some using special protocols such as 'iscsi://'. We'd like to switch to using the more modern -blockdev for PVE 9. The plan is to have the storage plugins return the very basic information required to access the image, and qemu-server can then add other settings like cache, aio, etc. on top. In fact, pretty similar to what we have now for -drive, just with a structured hash rather than a string. This is also a prerequisite for qemu-storage-deamon, that would be useful for TPM-as-qcow2 exported via NBD or FUSE or external backup provider restore providing an NBD export for the provider to write to. [0]: https://lore.kernel.org/qemu-devel/20250515112908.383693-1-f.eb...@proxmox.com/ Fiona Ebner (9): plugin: add method to get qemu blockdevice options for volume iscsi direct plugin: implement method to get qemu blockdevice options zfs iscsi plugin: implement new method to get qemu blockdevice options zfs pool plugin: implement method to get qemu blockdevice options ceph/rbd: set 'keyring' in ceph configuration for externally managed RBD storages rbd plugin: implement new method to get qemu blockdevice options plugin: qemu block device: add hints option and EFI disk hint plugin: qemu block device: add support for snapshot option plugin api: bump api version and age ApiChangeLog | 13 ++++ src/PVE/CephConfig.pm | 50 +++++++++++++++ src/PVE/Storage.pm | 21 +++++- src/PVE/Storage/ISCSIDirectPlugin.pm | 17 +++++ src/PVE/Storage/Plugin.pm | 96 ++++++++++++++++++++++++++++ src/PVE/Storage/RBDPlugin.pm | 62 ++++++++++++++++++ src/PVE/Storage/ZFSPlugin.pm | 19 ++++++ src/PVE/Storage/ZFSPoolPlugin.pm | 12 ++++ 8 files changed, 288 insertions(+), 2 deletions(-) -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
