--- Begin Message ---
>>+        my $blockdev =
>>PVE::QemuServer::Blockdev::generate_drive_blockdev($storecfg,
>>$device, {});
>>+        mon_cmd($vmid, 'blockdev-add', %$blockdev, timeout => 60);
>>+
>>+        return 1;

should we handle error here ?  (I don't known if a blockdev-add can
fail , and if it need 60s timeout like drive-add, as I think that the
blockdev open is done in device-add)




--- End Message ---
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to