Read the rules configuration in each round and update the canonicalized
rules configuration if there were any changes since the last round to
reduce the amount of times of verifying the rule set.

Signed-off-by: Daniel Kral <d.k...@proxmox.com>
---
changes since v1:
    - only read and canonicalize rules here... introduce the migration
      from groups to services and rules in a later patch

 src/PVE/HA/Manager.pm | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 85bb114..08c2fd3 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -8,6 +8,9 @@ use Digest::MD5 qw(md5_base64);
 use PVE::Tools;
 use PVE::HA::Tools ':exit_codes';
 use PVE::HA::NodeStatus;
+use PVE::HA::Rules;
+use PVE::HA::Rules::Location;
+use PVE::HA::Rules::Colocation;
 use PVE::HA::Usage::Basic;
 use PVE::HA::Usage::Static;
 
@@ -41,7 +44,11 @@ sub new {
 
     my $class = ref($this) || $this;
 
-    my $self = bless { haenv => $haenv, crs => {} }, $class;
+    my $self = bless {
+        haenv => $haenv,
+        crs => {},
+        last_rules_digest => '',
+    }, $class;
 
     my $old_ms = $haenv->read_manager_status();
 
@@ -556,6 +563,18 @@ sub manage {
         delete $ss->{$sid};
     }
 
+    my $new_rules = $haenv->read_rules_config();
+
+    if ($new_rules->{digest} ne $self->{last_rules_digest}) {
+
+        my $messages = PVE::HA::Rules->canonicalize($new_rules);
+        $haenv->log('info', $_) for @$messages;
+
+        $self->{rules} = $new_rules;
+
+        $self->{last_rules_digest} = $self->{rules}->{digest};
+    }
+
     $self->update_crm_commands();
 
     for (;;) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to