Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel:
> +sub generate_blockdev_drive_aio {
> + my ($drive, $scfg) = @_;
> +
> + my $cache_direct = drive_uses_cache_direct($drive, $scfg);
> + $drive->{aio} = 'threads' if drive_is_cdrom($drive);
We didn't force aio=threads for CD-ROMs before. In principle, it could
be fine (I'm going with the version guarded approach), but could you
provide some rationale for this change?
> + my $aio = $drive->{aio};
> + if (!$aio) {
> + if (storage_allows_io_uring_default($scfg, $cache_direct)) {
> + # io_uring supports all cache modes
> + $aio = "io_uring";
> + } else {
> + # aio native works only with O_DIRECT
> + if($cache_direct) {
> + $aio = "native";
> + } else {
> + $aio = "threads";
> + }
> + }
> + }
> + return $aio;
> +}
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
