On Mon, 26 May 2025 15:42:11 +0200, Lukas Wagner wrote: > The `Date` header in the generated email includes a timestamp with a > time zone offset (RFC 2822 format). This causes test failures when the > host system's time zone differs from CET/CEST, as the expected and > actual outputs no longer match. > > As a workaround, the `Date` header is excluded from comparisons between > the generated and reference emails.
It's really fine as workaround; in the long term we might want to parse and normalize the datetime values before comparision, but as we have no RFC 2822 parser available here we would either add that to proxmox-time, or evaluate if the newer and (from a shallow research) saner Jiff [0] crate would work for us, especially for cases where chrono failed (IIRC, panics, but might have been other stuff). Anyhow, the rfc2822 helper we use to render the epoch is not in this crate here, so it isn't really its job to test that function, and tbh. it's unlikely that we manage to introduce a regression for the date mail headers in this rather simple case. Meaning, there's really no priority to "fix" this, but if we ever got a RFC 2822 parser available here anyway it might as well be used here too. [0]: https://docs.rs/jiff/latest/jiff/#parsing-an-rfc-2822-datetime-string > > [...] Applied, thanks! [1/1] sendmail: fix test failures outside CET/CEST timezones commit: 972e0844dc49fdf12a77ba6597a5ee6ddf1fc23a _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
