Am 20.05.25 um 11:08 schrieb Michael Köppl:
> An explicit check for the existence of the storage is added to print a
> warning and continue with the removal of the container without deleting
> the mount point in case the storage does not exist anymore. For other
> errors, the function should still die.

And something else, while this is IMO fine to do for now as stop-gap, it
might be good to also improve the removal of storage entries, like e.g.,
if the storage is still available then check if there are any volumes
on the storage that our code recognizes, and if, prompt the user if they
still want to remove the storage entry, as that would make those volumes
unusable. Ideally we would join that info with them being actually used,
like a disk in a VM.
The same holds for jobs being defined that use that storage, like backup or
replication (well that always works on guest disks, so that would be
covered already).

For clarity: I do not suggest adding some "auto prune everything", that's
a tad to dangerous in the storage config panel/api. Albeit some multi
select + delete (and other operations that make sense, like move to other
storage I guess) could be nice, that probably should go into the storage
content UI/API.

Again, nothing wrong with this here, one can still always remove storage
entries directly, and improving UX on such edge cases is always nice.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to