Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update flutter app icons in iOS with proxmox icons

Dominik Csapak Wed, 21 May 2025 04:28:59 -0700

while i can't test the changes for ios, the images look good,
one question for my curiosity:


what triggered the changes in the Contents.json ?

AFAICS it's just reordering the properties + whitespace changes, which
make it hard to see if there was any actual change to the content...

not that I'm against it, but we should probably not unnecessarily touch these 
files,
except some tooling (e.g. from flutter) autoformats these or there
are real changes...

On 5/19/25 14:59, Shan Shaji wrote:

When running the app in iOS the app icon was the default flutter
icon and this commit fixes it by replacing all
flutter icons with the proxmox app icon.

Signed-off-by: Shan Shaji <s.sh...@proxmox.com>
---
  .../AppIcon.appiconset/Contents.json          | 160 +++++++++---------
  .../icon-app-1024x1...@1x.png                 | Bin 10932 -> 126022 bytes
  .../AppIcon.appiconset/icon-app-20...@1x.png  | Bin 295 -> 692 bytes
  .../AppIcon.appiconset/icon-app-20...@2x.png  | Bin 406 -> 2050 bytes
  .../AppIcon.appiconset/icon-app-20...@3x.png  | Bin 450 -> 3321 bytes
  .../AppIcon.appiconset/icon-app-29...@1x.png  | Bin 282 -> 1425 bytes
  .../AppIcon.appiconset/icon-app-29...@2x.png  | Bin 462 -> 3367 bytes
  .../AppIcon.appiconset/icon-app-29...@3x.png  | Bin 704 -> 5147 bytes
  .../AppIcon.appiconset/icon-app-40...@1x.png  | Bin 406 -> 2050 bytes
  .../AppIcon.appiconset/icon-app-40...@2x.png  | Bin 586 -> 4699 bytes
  .../AppIcon.appiconset/icon-app-40...@3x.png  | Bin 862 -> 7470 bytes
  .../AppIcon.appiconset/icon-app-60...@2x.png  | Bin 862 -> 7470 bytes
  .../AppIcon.appiconset/icon-app-60...@3x.png  | Bin 1674 -> 11744 bytes
  .../AppIcon.appiconset/icon-app-76...@1x.png  | Bin 762 -> 4378 bytes
  .../AppIcon.appiconset/icon-app-76...@2x.png  | Bin 1226 -> 9529 bytes
  .../icon-app-83.5x8...@2x.png                 | Bin 1418 -> 11072 bytes
  16 files changed, 80 insertions(+), 80 deletions(-)
  mode change 100644 => 100755 
ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json

diff --git a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json 
b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
old mode 100644
new mode 100755
index d36b1fa..9b6d103
--- a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
+++ b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
@@ -1,122 +1,122 @@
  {
-  "images" : [
+  "images": [
      {
-      "size" : "20x20",
-      "idiom" : "iphone",
-      "filename" : "icon-app-20...@2x.png",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "20x20",
+      "scale": "2x",
+      "filename": "icon-app-20...@2x.png"
      },
      {
-      "size" : "20x20",
-      "idiom" : "iphone",
-      "filename" : "icon-app-20...@3x.png",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "20x20",
+      "scale": "3x",
+      "filename": "icon-app-20...@3x.png"
      },
      {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "icon-app-29...@1x.png",
-      "scale" : "1x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "1x",
+      "filename": "icon-app-29...@1x.png"
      },
      {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "icon-app-29...@2x.png",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "2x",
+      "filename": "icon-app-29...@2x.png"
      },
      {
-      "size" : "29x29",
-      "idiom" : "iphone",
-      "filename" : "icon-app-29...@3x.png",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "3x",
+      "filename": "icon-app-29...@3x.png"
      },
      {
-      "size" : "40x40",
-      "idiom" : "iphone",
-      "filename" : "icon-app-40...@2x.png",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "2x",
+      "filename": "icon-app-40...@2x.png"
      },
      {
-      "size" : "40x40",
-      "idiom" : "iphone",
-      "filename" : "icon-app-40...@3x.png",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "3x",
+      "filename": "icon-app-40...@3x.png"
      },
      {
-      "size" : "60x60",
-      "idiom" : "iphone",
-      "filename" : "icon-app-60...@2x.png",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "2x",
+      "filename": "icon-app-60...@2x.png"
      },
      {
-      "size" : "60x60",
-      "idiom" : "iphone",
-      "filename" : "icon-app-60...@3x.png",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "3x",
+      "filename": "icon-app-60...@3x.png"
      },
      {
-      "size" : "20x20",
-      "idiom" : "ipad",
-      "filename" : "icon-app-20...@1x.png",
-      "scale" : "1x"
+      "idiom": "ipad",
+      "size": "20x20",
+      "scale": "1x",
+      "filename": "icon-app-20...@1x.png"
      },
      {
-      "size" : "20x20",
-      "idiom" : "ipad",
-      "filename" : "icon-app-20...@2x.png",
-      "scale" : "2x"
+      "idiom": "ipad",
+      "size": "20x20",
+      "scale": "2x",
+      "filename": "icon-app-20...@2x.png"
      },
      {
-      "size" : "29x29",
-      "idiom" : "ipad",
-      "filename" : "icon-app-29...@1x.png",
-      "scale" : "1x"
+      "idiom": "ipad",
+      "size": "29x29",
+      "scale": "1x",
+      "filename": "icon-app-29...@1x.png"
      },
      {
-      "size" : "29x29",
-      "idiom" : "ipad",
-      "filename" : "icon-app-29...@2x.png",
-      "scale" : "2x"
+      "idiom": "ipad",
+      "size": "29x29",
+      "scale": "2x",
+      "filename": "icon-app-29...@2x.png"
      },
      {
-      "size" : "40x40",
-      "idiom" : "ipad",
-      "filename" : "icon-app-40...@1x.png",
-      "scale" : "1x"
+      "idiom": "ipad",
+      "size": "40x40",
+      "scale": "1x",
+      "filename": "icon-app-40...@1x.png"
      },
      {
-      "size" : "40x40",
-      "idiom" : "ipad",
-      "filename" : "icon-app-40...@2x.png",
-      "scale" : "2x"
+      "idiom": "ipad",
+      "size": "40x40",
+      "scale": "2x",
+      "filename": "icon-app-40...@2x.png"
      },
      {
-      "size" : "76x76",
-      "idiom" : "ipad",
-      "filename" : "icon-app-76...@1x.png",
-      "scale" : "1x"
+      "idiom": "ipad",
+      "size": "76x76",
+      "scale": "1x",
+      "filename": "icon-app-76...@1x.png"
      },
      {
-      "size" : "76x76",
-      "idiom" : "ipad",
-      "filename" : "icon-app-76...@2x.png",
-      "scale" : "2x"
+      "idiom": "ipad",
+      "size": "76x76",
+      "scale": "2x",
+      "filename": "icon-app-76...@2x.png"
      },
      {
-      "size" : "83.5x83.5",
-      "idiom" : "ipad",
-      "filename" : "icon-app-83.5x8...@2x.png",
-      "scale" : "2x"
+      "idiom": "ipad",
+      "size": "83.5x83.5",
+      "scale": "2x",
+      "filename": "icon-app-83.5x8...@2x.png"
      },
      {
-      "size" : "1024x1024",
-      "idiom" : "ios-marketing",
-      "filename" : "icon-app-1024x1...@1x.png",
-      "scale" : "1x"
+      "size": "1024x1024",
+      "idiom": "ios-marketing",
+      "scale": "1x",
+      "filename": "icon-app-1024x1...@1x.png"
      }
    ],
-  "info" : {
-    "version" : 1,
-    "author" : "xcode"
+  "info": {
+    "version": 1,
+    "author": "xcode"
    }
  }

[snipped all the binary diffs]


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update flutter app icons in iOS with proxmox icons

Reply via email to