On Mon, 10 Mar 2025 09:50:56 +0100, Stefan Hanreich wrote:
> Create a helper method that abstracts the common code used in making
> netbox requests. Move all api_request incovations over to using the
> helper method. This saves us from writing lots of repeated code.
>
> This also updates the helpers and introduces error checking there.
> Helpers didn't catch any errors and the invoking methods didn't as
> well. This meant that functions with $noerr set to 1 would still error
> out. We now pass $noerr to the helper functions and they behave the
> same as the parent methods. This requires some additional checks in
> the call sites of the helpers.
>
> [...]
Applied, thanks!
[1/8] ipam: netbox: factor out common api methods and unify error handling
commit: f5a439d194109da893d0376c2833e9dd23f2de46
[2/8] ipam: netbox: implement deleting subnets
commit: 449e08a8fb15d2ba21936250af0c228abec8d22c
[3/8] ipam: netbox: simplify helpers
commit: cea37c09da99adcaef1d7cf7dbbd8aa82796030d
[4/8] ipam: netbox: no conditional assignments for descriptions
commit: 5ff8aeb080ae99230fc6d2825722f49fd0fca3c0
[5/8] ipam: netbox: add error handling to get_ips_from_mac
commit: b673a106c5b25a5d9e2586c51be764bfb01df506
[6/8] partial fix #5496: ipam: netbox: properly return allocated ip
commit: f36174e0722d82ea5473c17c3d901e30899fcb7b
[7/8] partial fix #5496: ipam: netbox: create / delete ip ranges for dhcp
commit: a52a40c78b82e0646c60a28fc9919336a2cb1290
[8/8] partial fix #5496: subnet: ipam: add update_subnet hook
commit: 1b01ad6529516790cc19b22c2c389e1c41530738
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
