On 4/7/25 11:27, Fabian Grünbichler wrote: > >> Stefan Hanreich <s.hanre...@proxmox.com> hat am 07.04.2025 10:51 CEST >> geschrieben: >> >> >> On 4/7/25 10:12, Thomas Lamprecht wrote: >>> Am 07.04.25 um 09:24 schrieb Fabian Grünbichler: >>>> On April 4, 2025 7:20 pm, Thomas Lamprecht wrote: >>>>> So, without looking at the implementation, fabrics have the IDs unique >>>>> per sub-type? Could maybe also share an ID space, less confusion >>>>> potential, but naturally also less flexibility – what do you think? >>>> >>>> they share a section config (and thus ID-space), so I guess we could >> >> There's one section config file per fabric, so its ID is unique per >> protocol. We'd need to load *all* configuration files everytime we >> change one configuration file (at least when adding a fabric) so we can >> validate unique IDs across all fabric types. > > mea culpa, must have mixed that up with something else (probably the > controllers :-/). would it make sense to merge them given the similarities?
The fabric section itself and the interface keys (contained in the node section) have very different properties (almost disjunct). That will only get exacerbated when adding e.g. Wireguard which is even more dissimilar as compared to OpenFabric/OSPF. We thought about having only one configuration file and introducing a section type per protocol and fabric / node combination, but that seemed unwieldy which is why we decided against it. >> Since we have plans of moving over the existing IS-IS + BGP controllers, > > those already have their own ACL paths, which makes this a bit messy then.. > or does that mean the old controller config and endpoints will be removed > in favor of their counterparts in fabrics? Yes, the intention is to completely move them over. I already talked shortly about it off-list with Thomas. Since we would need some form of migration script there, we would move it over during that process. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
