On 4/4/25 17:04, Thomas Lamprecht wrote:
Am 31.03.25 um 15:31 schrieb Michael Köppl:
Adds a formatted guest identifier (e.g. "VMID (VM name)") to the
SafeDestroy window. The formatted identifier is only used if it is
explicitly set by the caller. Otherwise, the VMID is used, avoiding
changes in behavior for other components.

Signed-off-by: Michael Köppl <m.koe...@proxmox.com>
---
  src/window/SafeDestroy.js | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

does not applies as is on my side here, might need a rebase or other
patches are missing?

Yes, this needed a rebase, sorry for that.

FWIW you could also use the nullish coalescing (??) operator instead
of a ternary and avoid the intermediate variable, e.g.:

     me.getItem().formattedIdentifier ?? itemId,

Thanks for the suggestion, applied it in a v3.

So please consider this

Superseded by:
https://lore.proxmox.com/pve-devel/20250407083806.63773-3-m.koe...@proxmox.com


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to