Am 04.04.25 um 14:53 schrieb Dominik Csapak:> qemu-server: > > Dominik Csapak (8): > tests: cfg2cmd: add test for windows machine pinning from meta info > config to command: get rid of globalFlags > machine: correctly select pve machine version for non pinned windows > guests > machine: incorporate pve machine version when pinning windows guests > machine: add S3/S4 power state properties > machine: bump pve machine version and reverse the s3/s4 defaults > api: qemu machine capabilities: add custom pveX versions too > api: qemu machine capabilities: add description for pveX variants
applied series, thanks! Tracking the changes of PVE versions is definitively filling a missing piece. I rework that handling a bit in a follow-up, unifying the two hashes to avoid running out of sync and also trying to make querying it slightly easier (e.g., no need for counter for-loop). Another check might be warranted to ensure I did not overlook something. The docs I rewrote mostly completely, to make the PVE machines a sub point of the overall machine version, as they are not really different, but only extend the mechanism we already used by something we can directly control. I tried to extend the previously existing machine version to also describe that we use that version for deciding what to enabled/change on the PVE side, i.e., not just what QEMU exposes, and also reduce some implementation details; another read would be great here too, when reworking parts locally thrice or more one starts to get to close to matter to see all obvious issues with the changes. While at it, I replaced the first-person plural (we) use with third person indicative mood as documented in our style guide [0]. [0]: https://pve.proxmox.com/wiki/Technical_Writing_Style_Guide#Person_and_Mood _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
