Am 26.03.25 um 13:04 schrieb Aaron Lauterer: > I did not find if we already have the full VM config already. AFAICT we > go from `qemu/Config.js` -> `VNCConsole.js`. > > Only the status of the VM. As I mentioned in the comment below the > commit msg, the backend does check against the wrong config property for > this use-case. > > So if we actually have the config already and I just couldn't find it, > point me to it :) > > Otherwise, to avoid additional API calls, the other options we have are: > > * change the backend check that populates `serial` in the status. It > currently checks against the presence of a serial device. But we need to > know if the display is set to serial, otherwise we get a false positive > if the serial device is used for a real physical serial device. > But I don't know where else (externally?) that might be used, therefore > I consider this a breaking change. > > * extend the vm status to have the infos we need. > ** property like "serialdisplay" > ** a "display" property that contains the configured display option? As vm_status already has all information parsed that required for this and already has a 'spice` boolean flag, it seems fine to handle that in vm_status. But it might be better to add a new slightly more general property where we can absorb the spice flag in the long run, like:
display: (serial;qxl;...) or already default to a property format-string now, but display: type=[serial;qxl;...] but we can transform it to that later one too if we're unsure about potential additional data added here, besides maybe merging in the clipboard too – then it might be better to have something like: user-interface: display=...[,clipboard=...][,...?] But no hard feelings on that, maybe someone else has input here, else I probably would go for `display: (serial;qxl;...)` for now. We need to handle "allow-spice" (as spice virt-viewer can be used for more than just QXL) then in the frontend though once we drop the spice flag then. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
