Thanks for testing! On Tue Apr 1, 2025 at 3:15 PM CEST, Daniel Kral wrote: [..] > Just tried to apply this, and it seems like the diff for the JSON files > is malformed as it splits the changes at roughly 1000 characters for the > changes to run-env*.json files: > > * run-env-info.json > * no_fqdn_from_dhcp.run-env.json > * fqdn_from_dhcp_no_default_domain.run-env.json
Right, thanks for noticing! That definitely is broken, unfortunately. Probably a hard-limit somewhere with 1000 characters per line along the line. The file directly from `git format-patch` looks fine, with no extra newlines. Sent the patches using `git send-email` as usual, so not sure where it went wrong. I'll see if I can reproduce it locally for me and fix it up for a v2. (Otherwise I'll just pretty-print/format these JSON files for v2.) > > I'm not sure what could have caused this, but after manually fixing > this, the rest of the patch applies cleanly and the tests run fine. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
