Tested the following scenarios: * Uploading a qcow2 image via the Web UI works fine. * Uploading a file that is not in the correct format fails with "Image is not in qcow2 format". * Adding a qcow2 image to an existing VM via the Web UI works fine. * Creating a VM with an imported qcow2 disk via the wizard works fine.
The minor "ugliness" that the storage selector resets when the "Import Image" checkbox is toggled is not a big problem in my opinion. Overall this looks fine. Tested-by: Filip Schauer <f.scha...@proxmox.com> On 25/03/2025 16:14, Dominik Csapak wrote:
most of the building blocks are already there: * we can have qcow2 files in an import storage * we can import qcow2 files via the api from such a storage this series fills in the missing bits & pieces: * allow uploading qcow2 files into an import storage via the webgui * adding the possibility to select such a file when creating a vm/disk We could maybe also allow this for raw/vmdk if we want to, but IMHO we can start out with qcow2 and add the others as necssary. (if wanted, I can of course also add the others in a next version or as a follow up) One minor "ugliness": when switching between import on/off, the target storage selector resets. This is normally intended by the component, since it's most often only disabled when it's still visible, except here in this case. If this is a blocker, I can of course add an option to the selector to not do this here, but IMHO this is a rather odd use case anyway, so I opted for not handling that explicitely. changes from v2: * fix correctly unset 'import-from' in wizard when going to summary, back to disk, unselecting import, then going forward to the summary again * fixed an issue with the file selector being mistakenly disabled changes from v1: * fixed an issue where the file selector would be hidden but invalid pve-storage: Dominik Csapak (1): import: allow upload of qcow2 files into import storage src/PVE/API2/Storage/Status.pm | 17 ++++++++++++++++- src/PVE/Storage.pm | 2 +- 2 files changed, 17 insertions(+), 2 deletions(-) pve-manager: Dominik Csapak (3): ui: storage content: allow upload of qcow2 for import type ui: form: file selector: allow optional filter ui: qemu hd edit: allow importing a disk from the import storage www/manager6/form/FileSelector.js | 10 ++++ www/manager6/qemu/HDEdit.js | 71 +++++++++++++++++++++++++- www/manager6/window/UploadToStorage.js | 2 +- 3 files changed, 81 insertions(+), 2 deletions(-)
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
