On 07/03/2025 13:29, Gabriel Goller wrote: > This includes a new frr-test-tools package that we are not interested in > (it's a testing package), so we ignore it with a BuildProfile. > > Signed-off-by: Gabriel Goller <g.gol...@proxmox.com> > --- > Makefile | 2 +- > debian/control | 9 +++++++++ > frr | 2 +- > 3 files changed, 11 insertions(+), 2 deletions(-) > >
applied series, thanks! I adapted the bump commit to use our common commit subject style and more importantly I fixed the versioning. As FRR is not developed by us we cannot use native versioning but need to split the native version and the packaging revision with a minus; this also ensures upgrades are correctly pulled in independently if the native part gets bumped by upstream or we bump the revision again for the same upstream version due to (packaging) changes on top of an upstream version that got already released to our package repos. I got some info for this in the packaging guide in our internal wiki (might make that public in the future) and it basically follows Debian, so you can also check out the respective section [0] of the Debian Policy Manual. [0]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#version I also backported libyang3 to satisfy updated build-dependency requirements of upstream, doing so itself is not a lot of work, but having to find out that this is needed is not only some extra work that can be avoided, it's also rather risky to slip through if it would only matter at runtime, causing some ugly breakage. So, the next time please ensure to build in a clean environment, e.g., using `sbuild` and a relatively minimal base image, and also check upstream for any newer dependency needs and update the Build-Depends section in debian/control accordingly. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
