On 3/6/25 17:42, Fiona Ebner wrote:
Am 13.02.25 um 14:17 schrieb Dominik Csapak:
we currently only call deactivate_volumes, but we actually want to call
the whole vm_stop_cleanup, since that is not invoked by the vm_stop
above (we cannot parse the config anymore) and might do other cleanups
we also want to do (like mdev cleanup).
For this to work properly we have to clone the original config at the
beginning, since we might modify the volids.
Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
applied, thanks!
It seems like other callers with nocheck are affected by this too?
Namely, live-restore upon failure and the remote_migration in some cases
(see the mtunnel API endpoint) also won't clean up the PCI devices etc.
IIUC, or am I missing something?
probably yes, I'll have to look, thanks for noticing that!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
