On 2/20/25 13:15, Fiona Ebner wrote:
I'd change the title to "alloc disk: fix content type check for ZFS
storages" because the check was missing for that branch ;)
The commit message should mention that there are already earlier checks
for the create operations. Moving a volume to a ZFS storage without
'rootdir' content type was still possible however, which this change
prohibits.
Nice catch, thanks for pointing that out! Haven't noticed that while
doing the refactor and will adapt the patch message as suggested for the
v3 :).
On 2/20/25 13:15, Fiona Ebner wrote:
I also noticed that we have no check against starting a container with
volumes on a storage that does not support 'rootdir'. We have such a
check for VMs IIRC. Prohibiting that would also be good, but maybe
something for PVE 9 where we can also check for misconfigured
containers/storages via the pve8to9 script up front so users can adapt.
Sounds good to have them both act the same in that regard! Put it on my
pve-9 todo list for now.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
