Am 04.02.25 um 17:44 schrieb Markus Frank: > > > On 2025-02-04 17:39, Fiona Ebner wrote: >> Am 04.02.25 um 17:21 schrieb Fiona Ebner: >>> Am 04.02.25 um 17:13 schrieb Markus Frank: >>>> Add an option to choose a file format (qcow2, raw, vmdk) when restoring >>>> a vm backup to file based storage. This options allows all disks to be >>>> recreated with the specified file format if supported by the target >>>> storage. >>>> >>>> Signed-off-by: Markus Frank <m.fr...@proxmox.com> >>>> --- >>>> Choosing the file format and storage for each disk would require much >>>> more change and would be more in line with Feature Request #4275. >>> >>> It's not that much more change. And if we add this now and then the >>> implementation for the other feature, we'll have duplicate/conflicting >>> options, which is also not nice. We can deprecate this option then of >>> course and later drop, but why not just go for the more complete >>> solution directly? Or at least a solution that can be built upon for >>> adding that feature later? >> >> Although I guess it can still serve as a fallback later too, so maybe we >> don't even need to drop it. For new multi-word options, please use >> kebap-case. Also, the option should not be "pve-qm-image-format", but >> "pve-storage-format".
(The reason is pve-qm-image-format contains more than our storage layer supports). But pve-storage-format is actually is also not fully correct, because it contains "subvol", which should not be used for VM images. We could think about adding a new in the storage layer (because that's where it needs to be supported) that includes only the ones that can be used for VM images. > > I have an idea how we could avoid deprecating this. > We could make this the default storage/format option, and override this > selection per vm disk if desired. > In the WebUI for example we could make this per disk selection in an > advanced tab. Yes, that's what I mean by "fallback" :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
