Also log an informational message just like for pending and snapshot
sections.
Add a comment about it to parse_vm_config() in the hope that the
behavior is noted when introducing a future special section.
Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
---
PVE/QemuServer.pm | 1 +
PVE/VZDump/QemuServer.pm | 12 ++++++++----
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index e0cca0e4..e1c9d3f5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2198,6 +2198,7 @@ sub parse_vm_config {
return if !defined($raw);
+ # note that pending, snapshot and special sections are currently skipped
when a backup is taken
my $res = {
digest => Digest::SHA::sha1_hex($raw),
snapshots => {},
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 72a76e65..cdaaa3a2 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -232,20 +232,21 @@ sub assemble {
my $found_snapshot;
my $found_pending;
- my $found_cloudinit;
+ my $found_special;
while (defined (my $line = <$conffd>)) {
next if $line =~ m/^\#vzdump\#/; # just to be sure
next if $line =~ m/^\#qmdump\#/; # just to be sure
if ($line =~ m/^\[(.*)\]\s*$/) {
if ($1 =~ m/^PENDING$/i) {
$found_pending = 1;
- } elsif ($1 =~ m/^special:cloudinit$/) {
- $found_cloudinit = 1;
+ } elsif ($1 =~ m/^special:.*$/) {
+ $found_special = 1;
} else {
$found_snapshot = 1;
}
}
- next if $found_snapshot || $found_pending || $found_cloudinit; # skip
all snapshots,pending changes and cloudinit config data
+ # skip all snapshots, pending changes and special sections
+ next if $found_snapshot || $found_pending || $found_special;
if ($line =~ m/^unused\d+:\s*(\S+)\s*/) {
$self->loginfo("skip unused drive '$1' (not included into backup)");
@@ -266,6 +267,9 @@ sub assemble {
}
}
+ if ($found_special) {
+ $self->loginfo("special config section found (not included into
backup)");
+ }
if ($found_snapshot) {
$self->loginfo("snapshots found (not included into backup)");
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
