Am 24.01.25 um 11:23 schrieb Fiona Ebner:
>> @@ -4017,7 +4018,7 @@ sub config_to_command {
>> push @$cmd, @$aa;
>> }
>>
>> - return wantarray ? ($cmd, $vollist, $spice_port, $pci_devices) : $cmd;
>> + return wantarray ? ($cmd, $vollist, $spice_port, $pci_devices, $conf) :
>> $cmd;
>> }
>>
>
> Hmm, thinking about it again, to reduce regression potential, we could
> also just return the temporary config if it was actually required and
> have the caller only assign it when really present.
Although I suppose it doesn't really give us anything after all. I was
worried a bit about things like potential auto-vivification, but since
we already use the original $conf hash ref throughout the function
(except in the template case), such things would already affect the caller.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
